Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions): add jaro_winkler string similarity function #16993

Merged
merged 3 commits into from
Dec 19, 2024
Merged

feat(functions): add jaro_winkler string similarity function #16993

merged 3 commits into from
Dec 19, 2024

Conversation

maxjustus
Copy link
Contributor

@maxjustus maxjustus commented Dec 4, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Adds a jaro_winkler string edit distance function taken from this project https://github.com/joshuaclayton/jaro_winkler

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 4, 2024
@BohuTANG BohuTANG requested a review from TCeason December 4, 2024 01:07
@maxjustus
Copy link
Contributor Author

ok @TCeason - I've moved the definition to other.rs

@TCeason
Copy link
Collaborator

TCeason commented Dec 12, 2024

ok @TCeason - I've moved the definition to other.rs

Please fmt code

@maxjustus
Copy link
Contributor Author

ok done @TCeason !

@TCeason
Copy link
Collaborator

TCeason commented Dec 16, 2024

ok done @TCeason !

Cool. But ci check failed.

TCeason
TCeason approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@TCeason TCeason added this pull request to the merge queue Dec 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 19, 2024
@BohuTANG BohuTANG merged commit 85c4caf into databendlabs:main Dec 19, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxjustus @TCeason @BohuTANG